Re: CVS commit: src/sys/arch

["Cherry G. Mathew" <cherry.g.mathew%gmail.com@localhost>]

On 7 January 2012 22:06, David Holland
<dholland-sourcechanges%netbsd.org@localhost> wrote:
> On Sat, Jan 07, 2012 at 12:36:32PM +0100, Manuel Bouyer wrote:
>  > > the problem is that now the code performs different operations
>  > > based upon DIAGNOSTIC or not.  it's not about whether it's wrong
>  > > or right, but that it's different.  DIAGNOSTIC shouldn't do more
>  > > or different things, just check stuff and assert if bad.
>  > >
>  > > if the hack works for DIAGNOSTIC, it seems generally right and
>  > > should be enabled for everyone now, until the real fix is
>  > > implemented.
>  >
>  > Seconded. Either that, or the DIAGNOSTIC printf which spams the
>  > console should be removed (I'm not sure why it has been added in the
>  > first place)
>
> Yeah... though I don't actually know what it's about, ISTM that if
> there's a harmless spammy printout, the right hack until things can be
> fixed properly is to silence the printout.
>
> Removing mappings can be expensive.
>

Reverted.

Thanks,
-- 
~Cherry