Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch

On Sat, Jan 07, 2012 at 06:01:07PM +1100, matthew green wrote:
> the problem is that now the code performs different operations
> based upon DIAGNOSTIC or not.  it's not about whether it's wrong
> or right, but that it's different.  DIAGNOSTIC shouldn't do more
> or different things, just check stuff and assert if bad.
> if the hack works for DIAGNOSTIC, it seems generally right and
> should be enabled for everyone now, until the real fix is
> implemented.

Seconded. Either that, or the DIAGNOSTIC printf which spams the
console should be removed (I'm not sure why it has been added in the
first place)

Manuel Bouyer <>
     NetBSD: 26 ans d'experience feront toujours la difference

Home | Main Index | Thread Index | Old Index