Re: CVS commit: src

[Paul Goyette <paul%whooppee.com@localhost>]

On Wed, 5 Jan 2011, Jeff Rizzo wrote:

> Module Name:    src
> Committed By:   riz
> Date:           Wed Jan  5 02:25:27 UTC 2011
>
> Modified Files:
>         src/distrib/sets/lists/tests: mi
>         src/tests/sbin/resize_ffs: Makefile common.sh t_grow.sh t_shrink.sh
> Added Files:
>         src/tests/sbin/resize_ffs: t_grow_swapped.sh t_shrink_swapped.sh
>
> Log Message:
> Update resize_ffs tests for byteswapped file system support, and
> for UFS2 growth support.  Also, reduce the number of tests run by default
> while still maintaining decent coverage of features and block sizes.
> Anyone working on resize_Ffs should run the tests with RESIZE_FFS_ALL_TESTS
> set in the environment, which adds a lot more testing.

Jeff,

I'm wondering if maybe it would be "more correct" to use an atf variable 
(ie, atf-run -v RESIZE_FFS_ALL_TESTS=true) rather than something in the 
environment?

As an example, take a look at my recent commit for 
src/tests/lib/libc/string/t_popcount.c

> To generate a diff of this commit:
> cvs rdiff -u -r1.206 -r1.207 src/distrib/sets/lists/tests/mi
> cvs rdiff -u -r1.2 -r1.3 src/tests/sbin/resize_ffs/Makefile
> cvs rdiff -u -r1.5 -r1.6 src/tests/sbin/resize_ffs/common.sh
> cvs rdiff -u -r1.6 -r1.7 src/tests/sbin/resize_ffs/t_grow.sh \
>    src/tests/sbin/resize_ffs/t_shrink.sh
> cvs rdiff -u -r0 -r1.1 src/tests/sbin/resize_ffs/t_grow_swapped.sh \
>    src/tests/sbin/resize_ffs/t_shrink_swapped.sh
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
>
> !DSPAM:4d23d69d2341473314484!

-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------