Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src

On Sun, Jan 02, 2011 at 12:58:13PM +0200, Antti Kantee wrote:
 > > Add an INRELOOKUP namei flag. Sigh. (We don't need more namei flags.)
 > > 
 > > However, because of a protocol deficiency puffs relies on being able
 > > to keep track of VOP_LOOKUP calls by inspecting their contents, and
 > > this at least allows it to use something vaguely principled instead of
 > > making wild guesses based on whether SAVESTART is set.
 > Well, not really.  That code in libp2k was compensating for file systems
 > wanting to modify some componentname flags in lookup and then expecting
 > them to be there (or not be there) come the time of the op itself.

Yes, and you yourself called it a protocol deficiency a while back.
Given the way componentname works it should really be treated as
INOUT, that is, picked up and shipped back after lookup runs.

all of that crap is going to go away... la la la

 > If componentname is guaranteed to be "opaque" (i.e. no
 > HASBUF/SAVENAME/START etc. mucking), you should be able to delete that
 > ugly code and flag and simply construct the componentnames passed to
 > VOP_RENAME from what puffs_rename gives you (but it's been a while,
 > so please test it if you implement it).

By the time that happens there won't be any componentnames any more. :-)

While HASBUF, SAVENAME, and SAVESTART are all dead now there's still a
bunch of flags that get flipped around, particularly
ISWHITEOUT/DOWHITEOUT, plus etfs still depends on mucking with
cn_consume, etc. etc.

But after this past weekend I think the path forward is now looking
pretty clear.

David A. Holland

Home | Main Index | Thread Index | Old Index