Re: CVS commit: src

[Antti Kantee <pooka%cs.hut.fi@localhost>]

On Sun Jan 02 2011 at 05:04:59 +0000, David A. Holland wrote:
> Module Name:  src
> Committed By: dholland
> Date:         Sun Jan  2 05:04:59 UTC 2011
> 
> Modified Files:
>       src/lib/libp2k: p2k.c
>       src/sys/kern: vfs_lookup.c
>       src/sys/sys: namei.src
> 
> Log Message:
> Add an INRELOOKUP namei flag. Sigh. (We don't need more namei flags.)
> 
> However, because of a protocol deficiency puffs relies on being able
> to keep track of VOP_LOOKUP calls by inspecting their contents, and
> this at least allows it to use something vaguely principled instead of
> making wild guesses based on whether SAVESTART is set.

Well, not really.  That code in libp2k was compensating for file systems
wanting to modify some componentname flags in lookup and then expecting
them to be there (or not be there) come the time of the op itself.

If componentname is guaranteed to be "opaque" (i.e. no
HASBUF/SAVENAME/START etc. mucking), you should be able to delete that
ugly code and flag and simply construct the componentnames passed to
VOP_RENAME from what puffs_rename gives you (but it's been a while,
so please test it if you implement it).

-- 
älä karot toivorikkauttas, kyl rätei ja lumpui piisaa