Re: CVS commit: src/external/cddl/osnet

[Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>]

christos%zoulas.com@localhost (Christos Zoulas) wrote:
> | 
> | It is consistent with the code in OpenSolaris, so it should not diverge.
> 
> This is changed code that would produce a diff in either case.
> It is more correct, and I don't see propagating a poor choice.
> OpenSolaris uses NULL for 0 in many places, should we do the same
> and turn off compiler warnings?

Are you planning to maintain this?  That should be something for the
maintainer to decide, since it is not a small and simple code base.

> | Also, while I see the benefits with *var (technically, it is against KNF,
> | by the way), my preference is to use type.
> 
> That was not an explicit preference, it was just a random choice, so I have
> corrected it.

That is arbitrary.  Can we please just stay relatively liberal (up to sane
point) about small style differences each developer has?  Otherwise we can
bikeshed about this until November.

-- 
Mindaugas