Re: CVS commit: src/external/cddl/osnet

[Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>]

christos%astron.com@localhost (Christos Zoulas) wrote:
> >Modified Files:
> >     src/external/cddl/osnet/dev/dtrace: dtrace_sysctl.c dtrace_unload.c
> >     src/external/cddl/osnet/dev/dtrace/amd64: dtrace_subr.c
> >     src/external/cddl/osnet/dev/dtrace/i386: dtrace_subr.c
> >     src/external/cddl/osnet/dist/uts/common/dtrace: dtrace.c
> >
> >Log Message:
> >Remove a couple of zero length kmem_frees.
> >
> >It should fix at least one crash when unloading the dtrace module,
> >possibly many others.
> 
> please use sizeof(*var) instead of sizeof(type)
> 

It is consistent with the code in OpenSolaris, so it should not diverge.

Also, while I see the benefits with *var (technically, it is against KNF,
by the way), my preference is to use type.

-- 
Mindaugas