Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/games/canfield/cfscores

On Fri, Jan 01, 2010 at 11:48:08PM +0000, Christos Zoulas wrote:
 > > > imo, lower case "usage" would be more consistent with other commands.
 > >
 > >Some grep usage suggests that lowercase outnumbers capitalized by a
 > >good margin, but there's still a healthy minority of capitalized usage
 > >messages. (It's about 500 to 125.)
 > >
 > >Is this something we care enough about to make a point of fixing it as
 > >we go?
 > I think consistency is good, but at the same time I like upper case :-)

Yeah, I think this should be left alone for the time being.

 > Also using errx() for usage is inconsistent because you end up printing
 > "prog: Usage: prog" instead of "Usage: prog". And everything should
 > consistently use getprogname() instead of hard-coding it.

Right. Fixed...

David A. Holland

Home | Main Index | Thread Index | Old Index