Re: CVS commit: src/games/canfield/cfscores

[christos%astron.com@localhost (Christos Zoulas)]

In article <20100101173538.GA17057%netbsd.org@localhost>,
David Holland  <dholland-sourcechanges%netbsd.org@localhost> wrote:
>On Fri, Jan 01, 2010 at 03:33:26PM +0100, Marc Balmer wrote:
> > >   if (argc > 2) {
> > > -         printf("Usage: cfscores -a | cfscores [user]\n");
> > > -         exit(1);
> > > +         errx(1, "Usage: cfscores -a | cfscores [user]");
> > 
> > imo, lower case "usage" would be more consistent with other commands.
>
>Some grep usage suggests that lowercase outnumbers capitalized by a
>good margin, but there's still a healthy minority of capitalized usage
>messages. (It's about 500 to 125.)
>
>Is this something we care enough about to make a point of fixing it as
>we go?

I think consistency is good, but at the same time I like upper case :-)
Also using errx() for usage is inconsistent because you end up printing
"prog: Usage: prog" instead of "Usage: prog". And everything should
consistently use getprogname() instead of hard-coding it.

christos