Re: CVS commit: src/usr.bin/ktruss

[Masao Uebayashi <uebayasi%tombi.co.jp@localhost>]

> > Modified Files:
> >     src/usr.bin/ktruss: Makefile
> > -   AWK=${TOOL_AWK:Q} CPP=${CPP:Q} CPPFLAGS=${CPPFLAGS:Q} \
> > +   ${GENCMD} ${.TARGET} \
> > +   AWK="${TOOL_AWK:Q}" CPP="${CPP:Q}" CPPFLAGS="${CPPFLAGS:Q}" \
> 
> The extra quotes here look wrong.  ${VAR:Q} should do the correct
> amount of quoting.  If you need two levels of quoting for some
> reason that I don't see, then use ${VAR:Q:Q}, not "${VAR:Q}".

:Q:Q seems to work, thanks.  The reason is ${GENCMD} uses eval.  Unlike
${MAKEDIRTARGET} arguments can have spaces...  This needs thought, yes.

Masao

-- 
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635