Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/ktruss



On Fri, 11 Dec 2009, Masao Uebayashi wrote:
> Modified Files:
>       src/usr.bin/ktruss: Makefile
> -     AWK=${TOOL_AWK:Q} CPP=${CPP:Q} CPPFLAGS=${CPPFLAGS:Q} \
> +     ${GENCMD} ${.TARGET} \
> +     AWK="${TOOL_AWK:Q}" CPP="${CPP:Q}" CPPFLAGS="${CPPFLAGS:Q}" \

The extra quotes here look wrong.  ${VAR:Q} should do the correct
amount of quoting.  If you need two levels of quoting for some
reason that I don't see, then use ${VAR:Q:Q}, not "${VAR:Q}".

--apb (Alan Barrett)


Home | Main Index | Thread Index | Old Index