Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev



On Tue, Nov 10, 2009 at 03:05:51PM -0500, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date:         Tue Nov 10 20:05:51 UTC 2009
> 
> Modified Files:
>       src/sys/dev: cgd.c cgdvar.h
> 
> Log Message:
> avoid variable array stack allocation by enforcing and allocating always the
> maximum.

The change isn't completely correct. The code will later use
"sizeof(sink)" and "sizeof(blkno_buf)" which is no the maximum and
not the actual buffer size.

You probably need to replace all those occurrences of "sizeof"
by "blocksize".

        Kind regards

-- 
Matthias Scheler                                  http://zhadum.org.uk/


Home | Main Index | Thread Index | Old Index