[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: [matt-nb5-mips64] src/sys/arch/mips/mips
Cliff Neighbors wrote:
> Module Name: src
> Committed By: cliff
> Date: Mon Nov 9 10:00:02 UTC 2009
> Modified Files:
> src/sys/arch/mips/mips [matt-nb5-mips64]: db_interface.c
> Log Message:
> - add MIPS64_SHOW32() and MIPS64_SHOW64() macros
> to show MIPS64 specific cp0 regs
Is the use of ".set mips64" safe in MIPS64_SHOW32 without the ".set
push"/".set pop" dance?
> - add EIRR, EIMR, EBASE, CONFIG[0,1,7] to show regs
> >>> these switched by runtime vairable is_rmi_xls
> is there a better variable to use ???
> cpu_arch == 64 ??
Querying cpu_id in db_interface.c is definitely wrong - maybe we should
add a new field to cputab in mips_machdep.c to say which CP0 regs are
available on each CPU. You should KNF the "is_rmi_xls=0" as well.
> - add mach mtcr, mfcr MD ddb commande
> >>> these are not runtime switched based on cpu arch,
> they are just 'there'
> if you use them on the wrong CPU, it's your problem!
Do these even link for a non-RMI config? You're unconditionally calling
rmi functions from "MI" MIPS code.
In general, I'm a tad concerned about the chip-specific code that is
getting added here.
Main Index |
Thread Index |