Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/make

On Fri, Mar 20, 2009 at 08:48:01PM +0000, Perry E. Metzger wrote:
 > Modified Files:
 >      src/usr.bin/make: Makefile main.c
 > Log Message:
 > The Makefile and main.c arranged to put "netbsd-${DATE}" into the
 > executable. Remove this so that different compiles can be binary
 > compared. rcsid's for all files are already embedded in the executable
 > so versions can be easily distinguished. (I didn't catch this on
 > previous passes because I did my builds on the same day.)
 > Note: there's a special rule for main.o in Makefile with a purpose I
 > can't actually discern -- I think it isn't needed, and I've flagged it
 > with a comment.

Given what you've removed, it has no further purpose.

However, I think you should put back the change to main.c that sets
MAKE_VERSION if passed on the command line; I suspect either pkgsrc
and/or sjg's portable release probably use it, and probably if we
aren't going to put a dynamic date into it from the makefile, we
should put a static date into it.

Maybe what we want to set it to is something like

  grep '$NetBSD' *.[ch] lst.lib/*.[ch] | sed 's,.*$NetBSD,,;s,/,,g' |\
    awk '{ print $4 }' | sort | tail -1

which would be the same for every build of the same sources but still
more or less reflect the date of -current.

David A. Holland

Home | Main Index | Thread Index | Old Index