Port-xen archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PAE support] Types + cosmetic fixes

On Wed, Feb 24, 2010 at 01:09:44AM +0100, Jean-Yves Migeon wrote:
>> I think it should be MIN(VM_MAXUSER_ADDRESS, ptoa(uvmexp.free).
>> Otherwise it's a change in behavior not related to i386PAE.
> Just checked, uvmexp elements are "int", so IMHO  
> ctob((rlim_t)uvmexp.free) is less error-prone (again, risk of overflow  
> with free > 4GB).

Yes, and clamped to VM_MAXUSER_ADDRESS if too large, in the i386 case.

Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference

Home | Main Index | Thread Index | Old Index