Re: Upgrade pkgsrc-wip/garage to v2.4.0

[Gergely Nagy <gergo%csillger.hu@localhost>]

Greg Troxel <gdt%lexort.com@localhost> writes:

> Gergely Nagy <gergo%csillger.hu@localhost> writes:
>
>> I wanted to use Garage, found a package for it in pkgsrc-wip, but it was
>> an ancient version. I went ahead and upgraded that to 2.4.0, then ran a
>> quick check to verify it shows signs of working. It seems to be
>> functioning fine, so the patch to upgrade it to 2.4.0 is attached.
>>
>> The upgrade removes the Cargo.toml patch, as it is no longer necessary
>> (upstream upgraded pnet_datalink to 0.35), and the libsodium dependency,
>> which also seems obsolete: Garage compiled fine without it, and
>> libsodium isn't a dependency in Garage's NixOS packaging either.
>
> I don't understand why you are mailing a patch to change wip, instead
> of asking for wip access and updating it.

Because I haven't touched NetBSD (and pkgsrc) in 20+ years up until two
weeks ago. I do *not* want to commit directly, and would prefer a review
by someone who knows what they're doing.

I'll ask for commit access to wip if and when I'm confident enough that
I can contribute good quality work.

> Either way, it's good to ask the people that previously contributed to
> the wip package, and presumably that's the CC.

I sent it to the maintainer, and put -users@ on CC, because the
maintainer listed haven't touched it since 2024 (and noone else did,
either), and their last commit to wip was in early 2024 too.

OTOH, you're the second person to tell me to just get a wip account, so
I'll consider doing that for future patches. :)

-- 
Gergely Nagy / |8]