pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Upgrade pkgsrc-wip/garage to v2.4.0



On Tue, 8 Sept 2026 at 13:25, Greg Troxel <gdt%lexort.com@localhost> wrote:
>
> Gergely Nagy <gergo%csillger.hu@localhost> writes:
>
> [ The mnxsolutions address is bouncing. ]
>
> > Greg Troxel <gdt%lexort.com@localhost> writes:
> >
> >> I don't understand why you are mailing a patch to change wip, instead
> >> of asking for wip access and updating it.

I took the liberty to update wip/garage to 2.4.0. The patch didn't
apply cleanly, but
it is a well-behaved rust package, so the standard update procedure

vi Makefile (change the version released)
 rm patches/patch-src_rpc_Cargo.toml  (project-specific)
 rmdir patches (no need)
 make fetch
 make distinfo
 make extract
 make print-cargo-depends > cargo-depends.mk
 make fetch
 make clean
 make distinfo
 make
 make package
 make install

worked out of the box:

# uname -a
NetBSD ym1r.lorien.lan 11.99.8 NetBSD 11.99.8 (GENERIC) #0: Thu Sep  3
06:36:49 BST 2026
root%ym1r.lorien.lan@localhost:/bd/sysbuild/amd64/obj/home/sysbuild/src/sys/arch/amd64/compile/GENERIC
amd64
# garage --version
garage git:1d8340bb45-modified [features: bundled-libs, k2v, lmdb,
metrics, sqlite


I haven't used it, will try it one of these days.

Chavdar

> >
> > Because I haven't touched NetBSD (and pkgsrc) in 20+ years up until two
> > weeks ago. I do *not* want to commit directly, and would prefer a review
> > by someone who knows what they're doing.
>
> I can see that, but the usual practice is first write to the maintainer
> or the person who added it, and ask them, and if they don't reply, go
> ahead.
>
> >> Either way, it's good to ask the people that previously contributed to
> >> the wip package, and presumably that's the CC.
> >
> > I sent it to the maintainer, and put -users@ on CC, because the
> > maintainer listed haven't touched it since 2024 (and noone else did,
> > either), and their last commit to wip was in early 2024 too.
> >
> > OTOH, you're the second person to tell me to just get a wip account, so
> > I'll consider doing that for future patches. :)
>
> wip is the place where we review.  It's far easier for me to just update
> wip and read things, and either add to TODO or fix things, than to mess
> with patches.
>
> The only real question is if you are confident that your changes are
> better than what's there, and a package that's 2.5 year out of date is
> definitely worse than one which is up to date and builds.   Basically,
> as a group we try to move everything to perfection, but as long as
> things are better it's progress.



-- 
----


Home | Main Index | Thread Index | Old Index