Re: rust-bin failing on macOS

[Jonathan Perkin <jperkin%mnx.io@localhost>]

* On 2024-11-28 at 15:16 GMT, Greg Troxel wrote:

> Now, pkg_add is objecting:
>
>  pkg_add: Missing required library: @rpath/librustc_driver-b80e59fe8421e0bc.dylib
>  pkg_add: Missing required library: @rpath/libstd-0e6078955cd7c66c.dylib
>  pkg_add: 1 package addition failed
>
> as far as I can tell with otool -L, there is no use of this path in the
> destdir, but I realize it's because of
>
> REQUIRES=@rpath/librustc_driver-b80e59fe8421e0bc.dylib
> REQUIRES=@rpath/libstd-0e6078955cd7c66c.dylib
>
> Then, looking again, I found two programs in destdir's bin that had
> @rpath.   I extended the @rpath remediation for them.
>
> So we have a situation where PKG_DEVELOPER is not sufficient to catch
> problems that pkg_add considers fatal (and also not overridable!!).

The files are being explicitly skipped:

  CHECK_SHLIBS_SKIP+=     bin/cargo-clippy
  CHECK_SHLIBS_SKIP+=     bin/rustfmt

However REQUIRES generation is only conditional on 
CHECK_SHLIBS_SUPPORTED, it's not per-file.

> So it would be nice, were Someone in the mood, to implement a check to
> catch this.

I don't think so, this is just a strange combination in the package 
where we are trying to fix some files but not others.  I'm not sure 
supporting this would be a good idea.

--
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com