Re: rust-bin failing on macOS

[Greg Troxel <gdt%lexort.com@localhost>]

Greg Troxel <gdt%lexort.com@localhost> writes:

> Thomas Klausner <wiz%gatalith.at@localhost> writes:
>
>> On Thu, Nov 28, 2024 at 09:10:03AM -0500, Greg Troxel wrote:
>>> On a macOS 13 (Ventura) system, otherwise up to date applewise and
>>> pkgsrc, rust-bin fails to package:
>>
>> The package has a large fix-darwin-install-name target that looks
>> related - perhaps it needs to be extended by a couple file names?
>
> Thanks - I did extend it.  There is now a fixup-needing file in libexec.

Now, pkg_add is objecting:

  pkg_add: Missing required library: @rpath/librustc_driver-b80e59fe8421e0bc.dylib
  pkg_add: Missing required library: @rpath/libstd-0e6078955cd7c66c.dylib
  pkg_add: 1 package addition failed

as far as I can tell with otool -L, there is no use of this path in the
destdir, but I realize it's because of

REQUIRES=@rpath/librustc_driver-b80e59fe8421e0bc.dylib
REQUIRES=@rpath/libstd-0e6078955cd7c66c.dylib

Then, looking again, I found two programs in destdir's bin that had
@rpath.   I extended the @rpath remediation for them.

So we have a situation where PKG_DEVELOPER is not sufficient to catch
problems that pkg_add considers fatal (and also not overridable!!).

So it would be nice, were Someone in the mood, to implement a check to
catch this.  Perhaps that is one of

  - any use of @rpath
  - use of a lib that is not in the buildlink tree or the base system

Looking for @rpath seems easiest, but will not catch everything.