Re: mail/offlineimap rfc6555 module dependency missing

[Greg Troxel <gdt%lexort.com@localhost>]

"J. Lewis Muir" <jlmuir%imca-cat.org@localhost> writes:

> On 08/02, Greg Troxel wrote:
>> "J. Lewis Muir" <jlmuir%imca-cat.org@localhost> writes:
>> > I don't think the rfc6555 module is in pkgsrc, so I think one solution
>> > would be to add it to pkgsrc and then to add it as a dependency of
>> > mail/offlineimap.
>> 
>> Sure.  You should feel free to add it to pkgsrc-wip.
>
> Well, I went to add it to wip/py-rfc6555, but it turns out it was
> already there.  Unfortunately, the date of the last commit on it is Mon
> Feb 14 10:36:00 2022 +0100.  Since I don't want to change someone else's
> wip work, I made changes to it locally, and I've included a diff of my
> changes to it below.

Write to the maintainer.  If they don't answer, change it.  If they do,
talk to to thema bout it.  It's great to be polite, but it's not
sensible to just defer without engaging.

Sending a diff here vs wip is in my view just more awkward.

> Then I found that py-rfc6555 needed the Python selectors2 module, so I
> added that at wip/py-selectors2.
>
> And then I needed to add the dependency on wip/py-rfc6555 to
> mail/offlineimap.  The diff for that is below also.

That would be "wip/offlineimap" as an upgrade candidate :-)

> With that, mail/offlineimap runs successfully for me on macOS Sonoma.

yay

> I'd like to request that these changes be committed to pkgsrc.

I hope somebody looks at them.  I have found that looking at
ready-to-commit work in wip, with COMMIT_MSG, is much more time
efficient, and thus tend not to look at other mechanisms unless they are
about a package for which I am $MAINTAINER.   In particular, writing a
commit message can often take figuring things out and that is usually
missing with patches.   Sorry to sound cranky....