On 5/22/23 06:42, Greg Troxel wrote:
Jason Bacon <jtocino%gmx.com@localhost> writes:On 5/21/23 17:41, Joerg Sonnenberger wrote:On Sat, May 20, 2023 at 07:29:19AM -0500, Jason Bacon wrote:Since it's not showing in the make output, I wonder if the pkgsrc wrapper is inserting it.It is. JoergMaybe the wrapper should check the filename extension before doing that, and leave it (-std=*++*) out for ".c" files.That sounds like a kludge. The pkgsrc doctrine is that invoking a C++ compiler for building a C file is a bug. Can you fix the makefile(heh) to have it call CC instead of CXX?
I certainly could, but I suspect upstream will argue that clang++ -x c file.c is perfectly valid, and we'll have to keep the patch around indefinitely. Even if they agree to change it, this may pop up in other packages, and someone will have to spend time solving this problem again. Question is what's more of a burden, dealing with patches like this one, or another if check in the wrapper code?