Re: chat/hexchat build failure

[Thomas Klausner <wiz%NetBSD.org@localhost>]

Hi Paul!

Looking good, please commit these.

Thanks,
 Thomas


On Mon, Apr 19, 2021 at 06:02:08AM -0700, Paul Goyette wrote:
> Thanks for the clue, wiz!
> 
> With the following changes, both hexchat and gnome-sudoku build and
> run correctly.
> 
> Index: hexchat/Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/chat/hexchat/Makefile,v
> retrieving revision 1.49
> diff -u -p -r1.49 Makefile
> --- hexchat/Makefile	5 Nov 2020 09:07:33 -0000	1.49
> +++ hexchat/Makefile	19 Apr 2021 13:00:02 -0000
> @@ -12,6 +12,10 @@ COMMENT=	IRC client based on XChat
>  LICENSE=	gnu-gpl-v2 AND gnu-lgpl-v2.1 AND mit
> 
>  USE_TOOLS+=	pkg-config msgfmt xgettext
> +
> +PYTHON_FOR_BUILD_ONLY=    tool
> +.include "../../lang/python/tool.mk"
> +
>  USE_LANGUAGES=	c c++
> 
>  # XXX fails without GNU msgfmt
> Index: gnome-sudoku/Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/games/gnome-sudoku/Makefile,v
> retrieving revision 1.35
> diff -u -p -r1.35 Makefile
> --- gnome-sudoku/Makefile	14 Apr 2021 07:28:18 -0000	1.35
> +++ gnome-sudoku/Makefile	19 Apr 2021 13:00:38 -0000
> @@ -15,6 +15,9 @@ USE_LANGUAGES=		c c++11
>  USE_PKGLOCALEDIR=	yes
>  USE_TOOLS+=		msgfmt pkg-config
> 
> +PYTHON_FOR_BUILD_ONLY=    tool
> +.include "../../lang/python/tool.mk"
> +
>  # Requires --desktop in msgfmt.
>  _TOOLS_USE_PKGSRC.msgfmt=	yes
> 
> 
> 
> On Mon, 19 Apr 2021, Thomas Klausner wrote:
> 
> > On Sun, Apr 18, 2021 at 03:43:38PM -0700, Paul Goyette wrote:
> > > On a amd64 host running NetBSD 9.99.81 (updated just prior to the switch
> > > from gcc-9 to -10, so still running -9), and with pkgsrc updated to just
> > > a few hours ago.  Starting from a completely empty chroot sandbox (as
> > > created by pkgtools/mksandbox), I've rebuilt everything (including all
> > > of hexchat's dependencies).
> > > 
> > > I'm seeing the following build failure:
> > > 
> > > ...
> > > ninja: Entering directory `output'
> > > [1/81] Generating textevents with a custom command
> > > FAILED: src/common/textevents.h src/common/textenums.h
> > > /tmp/pkgs/chat/hexchat/work.x86_64/hexchat-2.14.3/src/common/make-te.py ../src/common/textevents.in src/common/textevents.h src/common/textenums.h
> > > env: python3: No such file or directory
> > > ...
> > > 
> > > (The entire log file is only 16kb, so I've attached it to this E-mail.)
> > > 
> > > Anyone got any clues?
> > 
> > pkgsrc does not provide a "python3" binary by default, if you're not
> > using pkg_alternatives.
> > 
> > However, for building from pkgsrc, lang/python/tool.mk provides one.
> > This was until recently included from devel/meson/build.mk, but it's
> > not needed everywhere.
> > 
> > The fix is to include the file directly in chat/hexchat/Makefile, i.e. add
> > 
> > PYTHON_FOR_BUILD_ONLY=	  tool
> > .include "../../lang/python/tool.mk"
> > 
> > to the Makefile.
> > 
> > (If hexchat needs python at runtime, do not add the
> > PYTHON_FOR_BUILD_ONLY line.)
> > 
> > Cheers,
> > Thomas
> > 
> > !DSPAM:607cba41193741959012060!
> > 
> > 
> 
> +--------------------+--------------------------+-----------------------+
> | Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
> | (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
> | Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
> +--------------------+--------------------------+-----------------------+