Re: seg fault building npm

[Mike Pumford <mpumford%mudcovered.org.uk@localhost>]

On 09/11/2018 13:00, Chavdar Ivanov wrote:
> On Fri, 9 Nov 2018 at 12:42, Mike Pumford <mpumford%mudcovered.org.uk@localhost> wrote:
Not related to the issue at hand but I was reviewing the patch files to 
see if that gave any additional clues as to what might be going wrong.

Did spot one questionable patch but its not the cause of the SSL 
integration issues.

Offending patch is:

$NetBSD: patch-src_inspector__agent.cc,v 1.1 2017/06/05 21:14:04 fhajny 
Exp $

--- src/inspector_agent.cc.orig 2017-05-30 17:32:13.000000000 +0000
+++ src/inspector_agent.cc
@@ -96,7 +96,7 @@ static int RegisterDebugSignalHandler()
   // Don't shrink the thread's stack on FreeBSD.  Said platform decided to
   // follow the pthreads specification to the letter rather than in 
spirit:
   // 
https://lists.freebsd.org/pipermail/freebsd-current/2014-March/048885.html
-#ifndef __FreeBSD__
+#if defined(__FreeBSD__) && !defined(__NetBSD__)
   CHECK_EQ(0, pthread_attr_setstacksize(&attr, PTHREAD_STACK_MIN));
 #endif  // __FreeBSD__
   CHECK_EQ(0, pthread_attr_setdetachstate(&attr, 
PTHREAD_CREATE_DETACHED));

I think this patch reverses the #ifndef condition for freebsd. Adding a 
! before the defined(__FreeBSD__) would fix the issue.


Mike