Re: pkgsrc-2018Q2: pkgtools/pkgin fails to build

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2018-07-10 at 20:56 BST, Rhialto wrote:

> download.c: In function 'download_pkg':
> download.c:213:6: error: conversion to 'short unsigned int' from 'int' may alter its value [-Werror=conversion]
>       clearerr(fp);
>       ^
> cc1: all warnings being treated as errors
> *** [download.o] Error code 1

I don't understand this at all.  clearerr(3) is defined as

  void clearerr(FILE *stream);

so why is it complaining about int conversions?

This part of the code hasn't changed in 3 years, and builds with full
WARNS on the NetBSD/x86_64 7, NetBSD/vax 6, and NetBSD/arm 8.99.17
hosts I've tested it on, as well as Minix/SmartOS/macOS etc.

I'm happy to take a look, but could someone from NetBSD explain what's
going on here and what is special about this host?

Thanks,

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com