pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH] devel/talloc: Fix library install names on Darwin



On 2/18/16 12:21 PM, Greg Troxel wrote:
> I meant something less magic.   More like
>
> DARWIN_LIBS_FIXUP=
>   [list of libs, relative to DESTDIR, that need to be patched]
>
> DARWIN_LIBS_FIXUP_REFS=
>   [list of libs, relative to destdir, that need to be changed from the
>   destdir path to the eventual path, in all of the above]
>
> That would avoid open-coding the loop.

Yes, I think that would work assuming it would always do
the install_name_tool "-id" option for all libs listed in
DARWIN_LIBS_FIXUP regardless of what's in DARWIN_LIBS_FIXUP_REFS.
I say that because in the case of devel/talloc the install name
of libpytalloc-util.${PKGVERSION_NOREV}.dylib was actually
libpytalloc-util.inst.${PKGVERSION_NOREV}.dylib (note the ".inst"), so
that was a case where the name was being changed too, not just the path.

And then basically the references in DARWIN_LIBS_FIXUP_REFS would be
changed using the install_name_tool "-change" option.

Lewis


Home | Main Index | Thread Index | Old Index