pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH] devel/talloc: Fix library install names on Darwin



"J. Lewis Muir" <jlmuir%imca-cat.org@localhost> writes:

> On 2/18/16 10:39 AM, Greg Troxel wrote:
>> I am talking about easing the burden of adding workarounds.  OS X is
>> odd, and that means that these issue will continue to be common.  Your
>> changes were slightly hard to follow, and on reflection seem like they
>> could be factored out into a list of libraries to patch and a list of
>> dependencies to adjust, so that there would be two variables set, and
>> no need for the open-coded version.
>
> Ah, I see.  If there was some way to factor things out, then I agree
> that might be a nice help.  The install_name_tool "-id" option would be
> pretty easy.  The "-change" option would be a little harder because it
> needs the exact old-value string to be replaced, and that will likely
> vary.  But I suppose the infrastructure could figure out the exact
> old-value string using pattern matching on the output of "otool -L
> library_file".

I meant something less magic.   More like

DARWIN_LIBS_FIXUP=
  [list of libs, relative to DESTDIR, that need to be patched]

DARWIN_LIBS_FIXUP_REFS=
  [list of libs, relative to destdir, that need to be changed from the
  destdir path to the eventual path, in all of the above]

That would avoid open-coding the loop.

Attachment: signature.asc
Description: PGP signature



Home | Main Index | Thread Index | Old Index