Re: elinks-0.12pre6 patch : request to update

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Sat, Nov 03, 2012 at 08:53:03PM +0530, Mayuresh wrote:
> 0. I do not seem to know what the constraints are. But as a user it's a
> bit disappointing to not get javascript which unnecessarily limits what
> you can do using elinks, when upstream has provided the capability. Is it
> likely to be supported in future?

I understand, but I don't plan on working on this. Perhaps you can
take a look yourself what version of spidermonkey elinks wants and why
it doesn't accept the pkgsrc versions?

> 1. So should javascript option be removed from supported options
> altogether i.e. this line:
> 
>   4 PKG_SUPPORTED_OPTIONS+= bittorrent nntp javascript finger gopher

I've done that now, thanks.

> 2. Also, should these commented lines be removed?
> 
>  47 #.if !empty(PKG_OPTIONS:Mjavascript)
>  48 #.include "../../lang/spidermonkey/buildlink3.mk"
>  49 #CONFIGURE_ARGS+=   --with-spidermonkey
>  50 #CONFIGURE_ARGS+=   --enable-sm-scripting
>  51 #.else
>  52 #CONFIGURE_ARGS+=   --without-spidermonkey
>  53 #CONFIGURE_ARGS+=   --disable-sm-scripting
>  54 #.endif

I left them in to make it easier for whoever wants to tackle adding
javascript support again.
 Thomas