Re: patch-ab for librsvg

["Steven M. Bellovin" <smb%cs.columbia.edu@localhost>]

On Fri, 16 Jan 2009 09:31:06 +0900
"OBATA Akio" <obache%netbsd.org@localhost> wrote:

> Hi!
> 
> On Fri, 16 Jan 2009 07:30:30 +0900, Steven M. Bellovin
> <smb%cs.columbia.edu@localhost> wrote:
> 
> > The patch file for librsvg wants to delete some lines that no longer
> > exist.  The lines that should now be deleted are fairly obvious, but
> > the package seems to install correctly with nothing patched.  Should
> > the patch stay in existence?  (Second question: why doesn't patch
> > return an error code for a situation like that?)
> 
> It patch file has no problem for me.

Very strange -- I saw it on two different systems!

> After make clean & make extract,
> ${WRKSRC}/gdk-pixbuf-loader/Makefile.in has those lines noted in
> patch-ab, then after "make patch" and "mkpatches", "patchdiff" shows
> nothing. 
> 
> In addition, if the patch is not applicable, error messages should be
> rise.
> 
I saw a message, but the error code was such that make didn't object.

Let me check some more.

                --Steve Bellovin, http://www.cs.columbia.edu/~smb