Re: CVS commit: pkgsrc/graphics/py-tifffile

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Tue, Mar 09, 2021 at 07:06:30AM +0100, Adam wrote:
> David,
> 
> >> -PYTHON_VERSIONS_INCOMPATIBLE+= 27 36
> >> +PYTHON_VERSIONS_INCOMPATIBLE=  27 36
> > 
> > Hi Adam,
> > 
> > Two things about PYTHON_VERSIONS_INCOMPATIBLE. I'd changed it to the
> > "+=" form because of joerg@'s guidance about its usage last month.
> > 
> > http://mail-index.netbsd.org/pkgsrc-changes/2021/02/15/msg229136.html
> 
> Use += where you might add additional values to the variable somewhere else, which it not the case here.
> It's better to use += in Makefile.common, but in case of PYTHON_VERSIONS_INCOMPATIBLE I doubt it might be useful.

It can also be defined in mk.conf, which is one of the ways for disable
unwanted Python versions for bulk builds.

> > I was also curious as to why you marked 3.6 as incompatible (it built
> > fine for me with 3.6)? Is that because the upstream project states they
> > only test with 3.7 and up?
> 
> In setup.py, it states python_requires='>=3.7'. I believe there is a reason behind it. :)
> The package might build for Python 3.6, but does it work properly?

Run the tests?

Joerg