Re: CVS commit: pkgsrc/graphics/py-tifffile

[Adam <adam%netbsd.org@localhost>]

David,

>> -PYTHON_VERSIONS_INCOMPATIBLE+= 27 36
>> +PYTHON_VERSIONS_INCOMPATIBLE=  27 36
> 
> Hi Adam,
> 
> Two things about PYTHON_VERSIONS_INCOMPATIBLE. I'd changed it to the
> "+=" form because of joerg@'s guidance about its usage last month.
> 
> http://mail-index.netbsd.org/pkgsrc-changes/2021/02/15/msg229136.html

Use += where you might add additional values to the variable somewhere else, which it not the case here.
It's better to use += in Makefile.common, but in case of PYTHON_VERSIONS_INCOMPATIBLE I doubt it might be useful.


> While not a big deal, do you have a technical reason for changing it
> back? Am I misunderstanding something?
> 
> The only reason I was looking at that package originally was because
> your previous change to it broke bulk builds, when you added Python 3.6
> to the list there. I happened to notice it had further updates to it,
> and tested with them.
> 
> I was also curious as to why you marked 3.6 as incompatible (it built
> fine for me with 3.6)? Is that because the upstream project states they
> only test with 3.7 and up?

In setup.py, it states python_requires='>=3.7'. I believe there is a reason behind it. :)
The package might build for Python 3.6, but does it work properly?

Kind regards,
Adam