Re: CVS commit: pkgsrc/graphics/py-tifffile

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

On Mon, 8 Mar 2021 at 20:07:20 +0000, Adam Ciarcinski wrote:
>Module Name:    pkgsrc
>Committed By:   adam
>Date:           Mon Mar  8 20:07:20 UTC 2021
>
>Modified Files:
>        pkgsrc/graphics/py-tifffile: Makefile distinfo
>
>Log Message:
>py-tifffile: updated to 2021.3.5
>
>2021.3.5
>Pass 4390 tests.
>Preliminary support for EER format.
>Do not warn about unknown compression
>
>
>To generate a diff of this commit:
>cvs rdiff -u -r1.4 -r1.5 pkgsrc/graphics/py-tifffile/Makefile
>cvs rdiff -u -r1.3 -r1.4 pkgsrc/graphics/py-tifffile/distinfo
>
>Please note that diffs are not public domain; they are subject to the
>copyright notices on the relevant files.
>
>Modified files:
>
>Index: pkgsrc/graphics/py-tifffile/Makefile
>diff -u pkgsrc/graphics/py-tifffile/Makefile:1.4 pkgsrc/graphics/py-tifffile/Makefile:1.5
>--- pkgsrc/graphics/py-tifffile/Makefile:1.4    Fri Mar  5 04:21:05 2021
>+++ pkgsrc/graphics/py-tifffile/Makefile        Mon Mar  8 20:07:20 2021
>@@ -1,6 +1,6 @@
>-# $NetBSD: Makefile,v 1.4 2021/03/05 04:21:05 gutteridge Exp $
>+# $NetBSD: Makefile,v 1.5 2021/03/08 20:07:20 adam Exp $
> 
>-DISTNAME=      tifffile-2021.3.4
>+DISTNAME=      tifffile-2021.3.5
> PKGNAME=       ${PYPKGPREFIX}-${DISTNAME}
> CATEGORIES=    graphics python
> MASTER_SITES=  ${MASTER_SITE_PYPI:=t/tifffile/}
>@@ -12,7 +12,7 @@ LICENSE=      modified-bsd
> 
> USE_LANGUAGES= # none
> 
>-PYTHON_VERSIONS_INCOMPATIBLE+= 27 36
>+PYTHON_VERSIONS_INCOMPATIBLE=  27 36

Hi Adam,

Two things about PYTHON_VERSIONS_INCOMPATIBLE. I'd changed it to the
"+=" form because of joerg@'s guidance about its usage last month.

http://mail-index.netbsd.org/pkgsrc-changes/2021/02/15/msg229136.html

While not a big deal, do you have a technical reason for changing it
back? Am I misunderstanding something?

The only reason I was looking at that package originally was because
your previous change to it broke bulk builds, when you added Python 3.6
to the list there. I happened to notice it had further updates to it,
and tested with them.

I was also curious as to why you marked 3.6 as incompatible (it built
fine for me with 3.6)? Is that because the upstream project states they
only test with 3.7 and up?

Regards,

Dave