Re: CVS commit: pkgsrc/pkgtools/pkg_install

["Jonathan Perkin" <jperkin%joyent.com@localhost>]

* On 2012-10-09 at 10:04 BST, John Marino wrote:

> On 10/9/2012 10:38, Jonathan Perkin wrote:
> >* On 2012-10-09 at 08:36 BST, John Marino wrote:
> >
> >>Module Name:        pkgsrc
> >>Committed By:       marino
> >>Date:               Tue Oct  9 07:36:09 UTC 2012
> >>
> >>Modified Files:
> >>    pkgsrc/pkgtools/pkg_install: Makefile
> >>
> >>Log Message:
> >>pkgtools/pkg_install: Fix build on gcc4.7
> >>
> >>pkg_install uses source files from net/libfetch so it needs the same
> >>no-strict-alias flag at libfetch when building on gcc 4.7
> >
> >It would be good to clarify these commit messages, as we do not see
> >these issues with GCC 4.7 on SmartOS.
> 
> 
> What needs to be added to the commit message?
> That it's (apparently) not warning on all versions of gcc 4.7?
> The error is legitimate, so why isn't SmartOS's gcc picking it up?
> Are you using 4.7.2 ?

We use lang/gcc47, so 4.7.0 - are these newer warnings then?

Thanks,

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com