Re: CVS commit: pkgsrc/devel/kyua-cli

[John Marino <netbsd%marino.st@localhost>]

On 6/6/2012 14:11, Julio Merino wrote:
> On Jun 6, 2012 6:58 AM, "John Marino" <netbsd%marino.st@localhost 
> <mailto:netbsd%marino.st@localhost>> wrote:
>  >
>  > On 6/6/2012 00:37, Julio Merino wrote:
>  >> Care to explain why these changes are needed?  Fix DragonFly doesn't
>  >> indicate what exactly is broken.
>  >>
>  >
>  > The two patches add a header inclusion required for DragonFly.
>  > Since I review the commit set as a whole, I didn't think the commit 
> message needed to be any more explicit because it's pretty obvious what 
> the patches are doing:
>  > 
> https://github.com/jsonn/pkgsrc/commit/8de6459304054b331dba3b8fab87e8296e53c89f#devel/kyua-cli
> 
> I know what the patches _do_, but I don't know why. Why is that header 
> inclusion needed? What symbol needs it?
> 

These for example:
utils/process/children.cpp:130: error: 'S_IRUSR' was not declared in this scope
utils/process/children.cpp:130: error: 'S_IWUSR' was not declared in this scope
utils/process/children.cpp:130: error: 'S_IRGRP' was not declared in this scope
utils/process/children.cpp:130: error: 'S_IROTH' was not declared in this scope

You can imagine more than one package has this error without the sys/stat.h 
header included for DragonFly.
previous build log: 
http://leaf.dragonflybsd.org/~marino/masterbulk/20120519.2149/kyua-cli-0.3nb1/build.log

John