[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: pkgsrc/devel/kyua-cli
On Wed, 06 Jun 2012 19:58:07 +0900, John Marino <netbsd%marino.st@localhost>
On 6/6/2012 00:37, Julio Merino wrote:
On Thu, May 24, 2012 at 04:47:11PM +0000, John Marino wrote:
Module Name: pkgsrc
Committed By: marino
Date: Thu May 24 16:47:11 UTC 2012
devel/kyua-cli: Fix DragonFly
Care to explain why these changes are needed? Fix DragonFly doesn't
indicate what exactly is broken.
The two patches add a header inclusion required for DragonFly.
Since I review the commit set as a whole, I didn't think the commit
message needed to be any more explicit because it's pretty obvious what
the patches are doing:
It just explain `what', not `why'.
`Why' means, for example, "Require sys/stat.h for XXX on DragonFly",
or same failure may be risen again at different locations in the future.
Then, such information will be required for upstream developers (jmmv@).
OBATA Akio / obache%NetBSD.org@localhost
Main Index |
Thread Index |