Re: CVS commit: pkgsrc/devel/kyua-cli

["OBATA Akio" <obache%netbsd.org@localhost>]

On Wed, 06 Jun 2012 19:58:07 +0900, John Marino <netbsd%marino.st@localhost> 
wrote:

> On 6/6/2012 00:37, Julio Merino wrote:
> > On Thu, May 24, 2012 at 04:47:11PM +0000, John Marino wrote:
> > > Module Name:    pkgsrc
> > > Committed By:   marino
> > > Date:           Thu May 24 16:47:11 UTC 2012
> > >
> > > Modified Files:
> > >         pkgsrc/devel/kyua-cli: distinfo
> > > Added Files:
> > >         pkgsrc/devel/kyua-cli/patches: patch-utils_process_children.cpp
> > >             patch-utils_process_systembuf_test.cpp
> > >
> > > Log Message:
> > > devel/kyua-cli: Fix DragonFly
> >
> > Care to explain why these changes are needed?  Fix DragonFly doesn't
> > indicate what exactly is broken.
>
> The two patches add a header inclusion required for DragonFly.
> Since I review the commit set as a whole, I didn't think the commit
> message needed to be any more explicit because it's pretty obvious what
> the patches are doing:
> https://github.com/jsonn/pkgsrc/commit/8de6459304054b331dba3b8fab87e8296e53c89f#devel/kyua-cli

It just explain `what', not `why'.
`Why' means, for example, "Require sys/stat.h for XXX on DragonFly",
or same failure may be risen again at different locations in the future.
Then, such information will be required for upstream developers (jmmv@).

--
OBATA Akio / obache%NetBSD.org@localhost