Re: CVS commit: pkgsrc/devel/kyua-cli

[Julio Merino <jmmv%NetBSD.org@localhost>]

On Wed, Jun 6, 2012 at 8:25 AM, John Marino <netbsd%marino.st@localhost> wrote:
>
> These for example:
> utils/process/children.cpp:130: error: 'S_IRUSR' was not declared in this 
> scope
> utils/process/children.cpp:130: error: 'S_IWUSR' was not declared in this 
> scope
> utils/process/children.cpp:130: error: 'S_IRGRP' was not declared in this 
> scope
> utils/process/children.cpp:130: error: 'S_IROTH' was not declared in this 
> scope

Ah, I see.  Well, according to the documentation of chmod(2) in
various systems, sys/stat.h is a prerequisite for this call.
Therefore, the code was bogus in all such systems and not only
DragonFly... which means that the applied patches with conditional
includes are incomplete.

> You can imagine more than one package has this error without the sys/stat.h 
> header included for DragonFly.
> previous build log:

I could imagine if I tried (only now that you have shown what was
broken), but I should not be doing that.  The commit logs are there to
explain why things are done, so please try to be a bit more
descriptive.  Also, pkglint warns about your patches because they do
not contain a description at the top.  Hmm, writing the explanation in
there would be better in this case, I presume.

Anyway.  Thanks for the details.  I'll include this fix in the next release.

-- 
Julio Merino / @jmmv