pkg/59015: pkglint can't make up its mind about GMAKE_REQD

[campbell+netbsd%mumble.net@localhost]

>Number:         59015
>Category:       pkg
>Synopsis:       pkglint can't make up its mind about GMAKE_REQD
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 21 08:10:00 +0000 2025
>Originator:     Taylor R Campbell
>Release:        pkgsrc-current, pkglint-23.10.0
>Organization:
The GMAKE_REQD Lintation
>Environment:
>Description:
If I write

GMAKE_REQD+=		4.0

then pkglint complains:

WARN: Makefile:19: The "+=" operator should only be used with lists, not with GMAKE_REQD.

If I write

GMAKE_REQD=		4.0

then pkglint complains:

WARN: Makefile:19: Assignments to "GMAKE_REQD" should use "+=", not "=".

I think the correct is `=', not `+=', because GMAKE_REQD is not used as a list in the tools infrastructure (though maybe it should be):

TOOLS_DEPENDS.gmake?=		gmake>=${GMAKE_REQD}:../../devel/gmake
>How-To-Repeat:
1. set GMAKE_REQD any way you like
2. run pkglint
>Fix:
Yes, please!