Re: pkg/47415: lsof fails to compile under 5.2_STABLE

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/47415; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/47415: lsof fails to compile under 5.2_STABLE
Date: Thu, 4 Jul 2013 06:08:17 +0000

 On Sat, Jan 12, 2013 at 06:55:18AM +0000, Anne Bennett wrote:
  >>> In file included from dnode1.c:65:
  >>> /usr/include/isofs/cd9660/cd9660_node.h:75: error: expected ':', ',', ';' 
, '}' or '__attribute__' before '.' token
  >>  
  >> [...]
  >>    doff_t  i_endoff;
  >
  > [...]
  >  I just did a "make clean" and "make" in /usr/pkgsrc/sysutils/lsof, and
  >  I get the same error.  This is really mystifying.
 
 So, apparently I stepped on this problem in March on one of my
 machines, and fixed it without remembering there was an open PR on the
 same problem.
 
 The issue was i_endoff, not doff_t; the ufs_rename fixes #define
 i_endoff as a nested structure access (via code that's no longer in
 -current) so this broke the lsof build when it was merged into -5.
 
 It should be fixed now...
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost