pkg/47965: pkgsrc/math/fftw build fails on NetBSD/arm 6.1

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         47965
>Category:       pkg
>Synopsis:       pkgsrc/math/fftw build fails on NetBSD/arm 6.1
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 26 16:35:00 +0000 2013
>Originator:     Izumi Tsutsui
>Release:        NetBSD 6.1 and pkgsrc head around 20130623
>Organization:
>Environment:
System: NetBSD/evbarm 6.1 (HPT5325)
Architecture: arm
Machine: evbarm
>Description:
pkgsrc/math/fftw (required by SDL -> pulseaudio -> libsamplerate)
explicitly requires fortran support (it didn't on pkgsrc-2013Q1 BTW),
but lang/g95 doesn't support ARM so math/fftw build fails on NetBSD/arm.

>How-To-Repeat:
cd pkgsrc/math/fftw ; make
then g95 complains "not supported architecture."

>Fix:
Make fortran support an explicit option and
disable it on platforms which are not supported by g95
as x11/py-gtk2/options.mk does?
(not sure why it isn't an option currently)

---
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/math/fftw/Makefile,v
retrieving revision 1.44
diff -u -p -r1.44 Makefile
--- Makefile    7 Jun 2013 13:28:56 -0000       1.44
+++ Makefile    26 Jun 2013 16:23:31 -0000
@@ -19,11 +19,7 @@ USE_TOOLS+=          gmake
 GNU_CONFIGURE=         yes
 CONFIGURE_ARGS+=       --enable-shared
 
-# The next lines are fodder for a fortran option.
-# Swapping the comments doesn't change the PLIST.  So what's the
-# benefit of not?
-USE_LANGUAGES+=                fortran77
-# CONFIGURE_ARGS+=     --disable-fortran
+.include "options.mk"
 
 PKGCONFIG_OVERRIDE+=   fftw.pc.in
 INFO_FILES=            yes
Index: options.mk
===================================================================
RCS file: options.mk
diff -N options.mk
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ options.mk  26 Jun 2013 16:23:31 -0000
@@ -0,0 +1,18 @@
+# $NetBSD$
+
+PKG_OPTIONS_VAR=       PKG_OPTIONS.fftw
+PKG_SUPPORTED_OPTIONS= fftw-fortran
+.if (!empty(MACHINE_ARCH:Mi386) || !empty(MACHINE_ARCH:Mx86_64) || \
+       !empty(MACHINE_ARCH:Mia64) || !empty(MACHINE_ARCH:Mpowerpc*) || \
+       !empty(MACHINE_ARCH:Mhppa) || !empty(MACHINE_ARCH:Msparc*) || \
+       !empty(MACHINE_ARCH:Malpha) || !empty(MACHINE_ARCH:Mmips*))
+PKG_SUGGESTED_OPTIONS= fftw-fortran
+.endif
+
+.include "../../mk/bsd.options.mk"
+
+.if !empty(PKG_OPTIONS:Mfftw-fortran)
+USE_LANGUAGES+=                fortran77
+.else
+CONFIGURE_ARGS+=       --disable-fortran
+.endif

---

Probably it's better to have a common variable which represents
if the target platform is supported by g95/fortran77 or not?

---
Izumi Tsutsui