Re: pkg/47822: x11/modular-xorg-server 1.12.4 DragonFly x86_64 xf86_OSlib.h:284:27: fatal error: machine/mouse.h

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/47822; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/47822: x11/modular-xorg-server 1.12.4 DragonFly x86_64
 xf86_OSlib.h:284:27: fatal error: machine/mouse.h
Date: Sat, 1 Jun 2013 23:12:26 +0000

 On Sat, May 18, 2013 at 09:10:05PM +0000, David Shao wrote:
  >  I apologize if this is a totally ignorant quibble, but looking at the 
patch line
  >  
  >  +#if defined(__FreeBSD_kernel_version) && (__FreeBSD_kernel_version >=
  >  500013) || defined(__DragonFly__)
  >  
  >  I'm sure it is completely obvious the grouping is ( *** && *** ) ||
  >  ***, but I just don't know if the standards absolutely enforce that.
 
 They do. The precedence of binary operators in C is very clearly
 defined. Use operator(7) as a quick reference.
 
 That said, most people don't remember the order of || and && so it is
 usually a good idea to use parentheses. It's probably not worth going
 and changing the patch though.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost