pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/43081 (pkgsrc PHP specific version build machinery fails (NetBSD 4.0/i386))



The following reply was made to PR pkg/43081; it has been noted by GNATS.

From: Takahiro Kambe <taca%back-street.net@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: jdolecek%NetBSD.org@localhost
Subject: Re: pkg/43081 (pkgsrc PHP specific version build machinery fails
 (NetBSD 4.0/i386))
Date: Tue, 30 Mar 2010 23:18:52 +0900 (JST)

 Hi,
 
 In message <20100330115815.BF03C63B11D%www.NetBSD.org@localhost>
        on Tue, 30 Mar 2010 11:58:15 +0000 (UTC),
        wiz%NetBSD.org@localhost wrote:
 > Synopsis: pkgsrc PHP specific version build machinery fails (NetBSD 4.0/i386)
 > 
 > Responsible-Changed-From-To: pkg-manager->taca
 > Responsible-Changed-By: wiz%NetBSD.org@localhost
 > Responsible-Changed-When: Tue, 30 Mar 2010 11:58:14 +0000
 > Responsible-Changed-Why:
 > Can you please take a look at this?
 I looked at it.
 
 I think that this problem was derived by possible values for:
 
        PHP_VERSION_DEFAULT
        PHP_VERSIONS_ACCEPTED
        PHP_VERSION_REQD
        PKG_PHP_VERSION
 
 When I imported lang/php53, these variables take: 5 or 53.
 
        5       php 5.2.x
        53      php 5.3.x
 
 Next, jdolecek@, MAINTAINER of php package changes meaning:
 
        5       php 5.2.x or php 5.3.x
        52      php 5.2.x
        53      php 5.3.x
 
 It is logically good and consistent rather than making "5" means "52"
 when I imported.
 
 But, when recursive build is needed, lang/php/phpversion.mk is forced
 to set PHP_VERSION_REQD which is required to specify *real* PHP's
 version.
 
        # force the selected PHP version for recursive builds
        PHP_VERSION_REQD:=      ${PKG_PHP_VERSION}
 
 
 These are my analysis of present state and it could be fixed by
 possible value to:
 
        5       php 5.2.x
        53      php 5.3.x
 
 or
 
        52      php 5.2.x
        53      php 5.3.x
 
 Avoid to use value which means "php 5.2.x or php 5.3.x" or introduce
 new variable which set PHP_VERSION_REQD instead of PKG_PHP_VERSION
 above.
 
 Finally, since this decision should be done by MAINTAINER, this PR
 should be taken by jdolecek@.  :-)
 
 Best regards.
 
 -- 
 Takahiro Kambe <taca%back-street.net@localhost>
 


Home | Main Index | Thread Index | Old Index