pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Re: pkg/38988: Upgrade package to 9.05



Hello,

Sorry for the delay.

On Sun, Aug 10 2008 - 12:35, OBATA Akio wrote:
> The following reply was made to PR pkg/38988; it has been noted by GNATS.
> 
> From: "OBATA Akio" <obache%netbsd.org@localhost>
> To: gnats-bugs%netbsd.org@localhost
> Cc: 
> Subject: Re: pkg/38988: Upgrade package to 9.05
> Date: Sun, 10 Aug 2008 21:30:36 +0900
> 
>  On Thu, 19 Jun 2008 22:55:00 +0900, <joel%carnat.net@localhost> wrote:
>  
>  >>Description:
>  > This is just an upgrade to the latest stable version.
>  > I never had issue with the previous one but the upgrade looked pretty 
> straight forward.
>  
>  It seems not just an upgrade.
>  There are some questions.
>  
>  1. All CONFIGURE_* are removed.
>     Are those option useless in 9.05?
>  

Here's what I understood:
--enable-transparency           defaults to YES
--enable-menubar                Not Available (N/A)
--enable-xpm-background         N/A
--enable-xgetdefault            N/A
--enable-24bit                  N/A

Here's what my binary says:
# urxvt --help
rxvt-unicode (urxvt) v9.05 - released: 2008-06-15
options: 
perl,xft,styles,combining,blink,iso14755,unicode3,encodings=eu+vn+jp+jp-ext+kr+zh+zh-ext,fade,transparent,tint,XIM,frills,selectionscrolling,wheel,slipwheel,cursorBlink,pointerBlank,scrollbars=plain+rxvt+NeXT+xterm
Usage: urxvt [options] [-e command args]
<snip>

>  2. USE_FEATURES+=snprintf also missing.
>     Is it changed not to use snprintf?

I don't know.
I first tried building without the option.
And as it compiled and worked well, I didn't uncomment it.

I left the line commented so that a someone knowing more about snprintf than
I do could point out if this was an error.

>  
>  3. post-install target(installation of documentation, termcap and terminfo) 
> is memoved.
>     Why?
>  

Same I above: I just run "make install && make print-PLIST > PLIST".
Everything works OK so I didn't digg more.

>  4. perl option is still alive in options.mk, but in Makefile, fixed to use 
> perl and
>     PLIST is uncondifionally.
>     9.05 can't build without perl, or useless, or just forgotten?

"--enable-perl" is a configure option.
I removed "perl" from the Makefile and run "env
PKG_OPTIONS.rxvt-unicode=-perl make package"
It compiled OK but the package task stopped because some perl references
where in PLIST but not installed.

##########
=> Registering installation for rxvt-unicode-9.05
pkg_admin: rxvt-unicode-9.05: File
`/usr/pkg/lib/urxvt/perl/block-graphics-to-ascii' is in +CONTENTS but
not on filesystem!
pkg_admin: rxvt-unicode-9.05: File
`/usr/pkg/lib/urxvt/perl/digital-clock' is in +CONTENTS but not on
filesystem!
pkg_admin: rxvt-unicode-9.05: File
`/usr/pkg/lib/urxvt/perl/example-refresh-hooks' is in +CONTENTS but not
on filesystem!
pkg_admin: rxvt-unicode-9.05: File `/usr/pkg/lib/urxvt/perl/kuake' is in
+CONTENTS but not on filesystem!
pkg_admin: rxvt-unicode-9.05: File
`/usr/pkg/lib/urxvt/perl/macosx-clipboard' is in +CONTENTS but not on
filesystem!
pkg_admin: rxvt-unicode-9.05: File `/usr/pkg/lib/urxvt/perl/matcher' is
in +CONTENTS but not on filesystem!
pkg_admin: rxvt-unicode-9.05: File
`/usr/pkg/lib/urxvt/perl/option-popup' is in +CONTENTS but not on
filesystem!
pkg_admin: rxvt-unicode-9.05: File `/usr/pkg/lib/urxvt/perl/readline' is
in +CONTENTS but not on filesystem!
pkg_admin: rxvt-unicode-9.05: File
`/usr/pkg/lib/urxvt/perl/remote-clipboard' is in +CONTENTS but not on
filesystem!
pkg_admin: rxvt-unicode-9.05: File
`/usr/pkg/lib/urxvt/perl/searchable-scrollback' is in +CONTENTS but not
on filesystem!
pkg_admin: rxvt-unicode-9.05: File `/usr/pkg/lib/urxvt/perl/selection'
is in +CONTENTS but not on filesystem!
pkg_admin: rxvt-unicode-9.05: File
`/usr/pkg/lib/urxvt/perl/selection-autotransform' is in +CONTENTS but
not on filesystem!
pkg_admin: rxvt-unicode-9.05: File
`/usr/pkg/lib/urxvt/perl/selection-pastebin' is in +CONTENTS but not on
filesystem!
pkg_admin: rxvt-unicode-9.05: File
`/usr/pkg/lib/urxvt/perl/selection-popup' is in +CONTENTS but not on
filesystem!
pkg_admin: rxvt-unicode-9.05: File `/usr/pkg/lib/urxvt/perl/tabbed' is
in +CONTENTS but not on filesystem!
pkg_admin: rxvt-unicode-9.05: File `/usr/pkg/lib/urxvt/perl/urxvt-popup'
is in +CONTENTS but not on filesystem!
pkg_admin: rxvt-unicode-9.05: File
`/usr/pkg/lib/urxvt/perl/xim-onthespot' is in +CONTENTS but not on
filesystem!
pkg_admin: rxvt-unicode-9.05: File `/usr/pkg/lib/urxvt/urxvt.pm' is in
+CONTENTS but not on filesystem!
pkg_admin: rxvt-unicode-9.05: File `/usr/pkg/man/man3/urxvtperl.3' is in
+CONTENTS but not on filesystem!
##########

So to answer your question, perl can be removed from Makefile and left
as an options but PLIST has to be modified to reflect the fact that the
perl options installs additional files. I'm not sure how to do that.

>  
>  5. wip/libev/buildlink3.mk is commented out.
>     9.05 should be used with libev package?

I think it is.

When I started building this package I read that it requires libev.
So I tried adding a wip/libev first but couldn't succeed.
I don't remember how&why but I discovered urxvt did provide libev in
its source tree.

I left the comment in the Makefile so that one can decide if it is
better to have a separate libev package or use the provided one.

>  
>  6. patch-ab is missing (fixes CVE-2008-1142).
>     9.05 is not contains it (Just mentioned in man, default display is :0).
>     Really no need the patch? 
>  

As far as I could understand the code, the source file seems to include
the patch.

Hope this helps.
Regards,
        Jo


Attachment: pgpeHSxGak2Jr.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index