Re: NetBSD-9.4 and SSP

[Sad Clouds <cryintothebluesky%gmail.com@localhost>]

On Mon, 21 Oct 2024 07:36:58 +0000 (UTC)
RVP <rvp%SDF.ORG@localhost> wrote:

> On Mon, 21 Oct 2024, Sad Clouds wrote:
> 
> > Hi, thanks for the pointers. Looks like wm/cde includes a copy of ksh,
> > so I applied the first patch you linked. It is still failing in the
> > same place, even after cleaning up all object files.
> >
> 
> Did that iffe test succeed in detecting SYS___getcwd after the patch?
> If not, you'll have to find out why it didn't.
> 
> > I logged the actual compiler command, see below. So removing
> > -D_FORTIFY_SOURCE=2 resolves the issue. If NetBSD getcwd() issue was
> > fixed back in 2023, how come this fix did not make to 9.4_STABLE?
> >
> 
> You can always ask for a pull-up. Contact christos@/martin@
> 
> -RVP

Yes, once I applied this patch
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/shells/ksh93/patches/patch-src_lib_libast_features_syscall?rev=1.4

The test succeeds, but gcc returns error "redefinition of 'getcwd'"
which is more of a NetBSD + SSP issue. This looks like a regression
from NetBSD-9.3, although I'm not sure if -D_FORTIFY_SOURCE=2 flag was
always there, or recently added with pkgsrc-2024Q3.