NetBSD-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Bump - Non-functional xfreerdp2 on 8.1 STABLE - missing POSIX timer_create?




On 17.11.2020 18:16, Bodie wrote:
On 17.11.2020 18:06, nia wrote:
I read the actual code that uses POSIX timers, it hasn't changed at all
in the various release candidates.

It all started with this https://github.com/FreeRDP/FreeRDP/issues/4592

If you want to simulate building with POSIX timer support disabled,
you can do the following:

BUILDLINK_TRANSFORM+=	rm:-DWITH_POSIX_TIMER

The FreeBSD-related PR you linked to enables Linux epoll emulation for
a specific code path.

If you want to test if that code path is reached, edit the
"os specific implementation is missing" messages in
work/freerdp-2.1.2/winpr/libwinpr/synch/timer.c.

Note that there are two such messages, and both are identical.
It would be useful to know which one is being triggered.

It's possible we need to either:

1) Enable the "__APPLE__" code paths in that file on NetBSD too.

2) Borrow the epoll emulation code.

I can't test this because I don't have a Windows machine to connect to...
I can test as I do have access to various versions of Windows. In fact 
I am
testing in any case as it will be good to have working. Probably I will
start with going to current to see the difference as Martin says it somewhat
works for him
So here is the test:

netbsd$ xfreerdp2 --version
This is FreeRDP version 2.1.2 (2.1.2)
netbsd$ uname -a
NetBSD netbsd 9.99.75 NetBSD 9.99.75 (GENERIC) #0: Tue Nov 17 04:50:29 UTC 2020 mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/amd64/compile/GENERIC amd64
netbsd$

compiled freerdp2 from current pkgsrc

against Windows server 2016 build 1607:

[07:01:46:382] [19612:dbca8000] [INFO][com.freerdp.gdi] - Local framebuffer format PIXEL_FORMAT_BGRX32 [07:01:46:382] [19612:dbca8000] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_RGB16 [07:01:46:439] [19612:dbca8000] [INFO][com.winpr.clipboard] - initialized POSIX local file subsystem [07:01:46:458] [19612:dbca8000] [INFO][com.freerdp.channels.rdpsnd.client] - [static] Loaded fake backend for rdpsnd [07:01:46:459] [19612:dbca8000] [ERROR][com.winpr.synch.timer] - InitializeWaitableTimer: os specific implementation is missing
netbsd$

This is without any modifications anywhere.


Home | Main Index | Thread Index | Old Index