PR/59624 CVS commit: [netbsd-11] src/sys/dev/usb

["Martin Husemann" <martin%netbsd.org@localhost>]

The following reply was made to PR install/59624; it has been noted by GNATS.

From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/59624 CVS commit: [netbsd-11] src/sys/dev/usb
Date: Sun, 19 Oct 2025 10:08:33 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sun Oct 19 10:08:33 UTC 2025
 
 Modified Files:
 	src/sys/dev/usb [netbsd-11]: usb_subr.c usbdivar.h xhci.c
 
 Log Message:
 Pull up following revision(s) (requested by riastradh in ticket #58):
 
 	sys/dev/usb/xhci.c: revision 1.191
 	sys/dev/usb/usb_subr.c: revision 1.280
 	sys/dev/usb/usb_subr.c: revision 1.281
 	sys/dev/usb/usbdivar.h: revision 1.140
 
 usb(9): Record config index, not just number, in struct usbd_device.
 
 The index is a zero-based index in [0, bNumConfigurations), or -1 for
 unconfigured.
 
 The number is an arbitrary value of a config descriptor's
 bConfigurationValue field, or 0 for unconfigured -- with the tricky
 caveat that bConfigurationValue might also be 0.
 
 Preparation for fixing:
 PR kern/59185: panic over KASSERTMSG(dev->ud_ifaces == NULL) on Dell
 Latitude 7490
 PR kern/59624: Booting NetBSD-11 from USB on my Dell machine panics
 and hangs
 PR kern/57447: HEAD fails to probe USB devices and fails to boot up
 
 usb(9): Use ud_configidx, not ud_config, to see if unconfigured.
 ud_config is a device-provided quantity in the config descriptor's
 bConfigurationValue, and a faulty (or malicious) device can provide 0
 for that value, which coincides with our software sentinel value
 USBD_UNCONFIG_NO of 0.
 
 Instead of testing ud_config, test ud_configidx, which is an index in
 [0, bNumConfigurations) or -1, for which the device cannot confuse us
 by a value that coincides with the sentinel -1.
 
 PR kern/59185: panic over KASSERTMSG(dev->ud_ifaces == NULL) on Dell
 Latitude 7490
 PR kern/59624: Booting NetBSD-11 from USB on my Dell machine panics
 and hangs
 PR kern/57447: HEAD fails to probe USB devices and fails to boot up
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.279 -r1.279.4.1 src/sys/dev/usb/usb_subr.c
 cvs rdiff -u -r1.139 -r1.139.2.1 src/sys/dev/usb/usbdivar.h
 cvs rdiff -u -r1.188.2.2 -r1.188.2.3 src/sys/dev/usb/xhci.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.