Re: kern/59486: compat_linux should ignore IP_MULTICAST_ALL

["mc36 via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR kern/59486; it has been noted by GNATS.

From: mc36 <csmate%nop.hu@localhost>
To: gnats-bugs%netbsd.org@localhost, kern-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost, mc36%freemail.hu@localhost, netbsd-bugs%netbsd.org@localhost
Cc: Christoph Badura <bad%bsd.de@localhost>
Subject: Re: kern/59486: compat_linux should ignore IP_MULTICAST_ALL
Date: Fri, 27 Jun 2025 13:53:58 +0200

 This is a multi-part message in MIME format.
 --------------HXuMbjERfAh4cl99yy0iOL4o
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 7bit
 
 hi team, christoph,
 
 first of all, attaching the latest patch and the rest to play with....
 
 On 6/27/25 10:10, Christoph Badura via gnats wrote:
 >   
 >   Isn't this in the wrong places?  level is IPPROTO_IP not IPPROTO_UDP.
 >   
 
 field testing showed that i was wrong in the original patch about the _udp part, spot level=1:
 
 # LD_PRELOAD=/rtr/sockhook.so /java/bin/java -jar /rtr/rtr.jar routerc /rtr/rtr-
 
 
    ####                       ##################
   ##                                  ##
   ##  ## ###   #####   #####  ## ###  ## ## ###
 ####  ### ## ##   ## ##   ##  ### ## ##  ### ##
   ##   ##  ## ####### #######  ##  ## ##  ##  ##
   ##   ##     ##      ##       ##     ##  ##
   ##   ##     ##   ## ##   ##  ##     ##  ##
   ##   ##      #####   #####   ##     ##  ##
 
 freeRouter v25.6.27-cur, done by sprscc13@mrn0b0dy.
 
 place on the web: http://www.freertr.org/
 license: http://creativecommons.org/licenses/by-sa/4.0/
 the beer-ware license for selected group of people:
 sprscc13@mrn0b0dy wrote these files. as long as you retain this notice you
 can do whatever you want with this stuff. if we meet some day, and
 you think this stuff is worth it, you can buy me a beer in return
 
 info cfgInit.doInit:cfgInit.java:1168 booting
 info cfgInit.doInit:cfgInit.java:1417 initializing hardware
 hook called level=1 optname=15 res=-1 errno=22!
 hook called level=0 optname=49 res=-1 errno=92!
 hook called level=1 optname=6 res=0 errno=92!
 hook called level=1 optname=2 res=0 errno=92!
 hook called level=1 optname=8 res=-1 errno=105!
 hook called level=1 optname=7 res=-1 errno=105!
 info cfgInit.doInit:cfgInit.java:1423 applying defaults
 info cfgInit.doInit:cfgInit.java:1450 applying configuration
 info cfgInit.doInit:cfgInit.java:1487 boot completed
 welcome
 line ready
 yourname#
 
 ps: with the patch in the module, it works without the hook faking success too.... :)
 
 
 
 >   Wouldn't it be better to return ENOPROTOOPT?  Because that's what the java
 >   code expects?
 >   
 
 cannot disagree, its better not to fake a success....
 
 
 >   Also, you're missing the equivalent changes for IPv6.
 >   
 
 just added things needed for a plain [::1]:1234, see in the updated test java code....
 
 
 >   Could you update your changes to be more complete?
 >   
 
 above the already discussed changes, now i added the getsockopts aligned to the old and new return codes too...
 
 
  > Did you check that we don't need to translate any structures?
  >
 
 so the now passing-through setsockopts deals with raw options as they appear on the wire so i assume no extra work needed here...
 
 
  > Thank you for working on this.
  >
 
 it's my pleasure that you're giving me feedback (and hopefully accepting the patch when things got sorted out:)
 
 
 have a nice weekend,
 
 csaba
 
 --------------HXuMbjERfAh4cl99yy0iOL4o
 Content-Type: text/plain; charset=UTF-8; name="patch"
 Content-Disposition: attachment; filename="patch"
 Content-Transfer-Encoding: base64
 
 ZGlmZiAtY3JCIGEvbGludXhfc29ja2V0LmMgYi9saW51eF9zb2NrZXQuYwoqKiogYS9saW51
 eF9zb2NrZXQuYwkyMDIxLTA5LTIzIDA4OjU2OjI3LjAwMDAwMDAwMCArMDIwMAotLS0gYi9s
 aW51eF9zb2NrZXQuYwkyMDI1LTA2LTI3IDEzOjE2OjMyLjQyMDA1NzY0MiArMDIwMAoqKioq
 KioqKioqKioqKioKKioqIDk0NSw5NTAgKioqKgotLS0gOTQ1LDk1NiAtLS0tCiAgCQlyZXR1
 cm4gSVBfVE9TOwogIAljYXNlIExJTlVYX0lQX1RUTDoKICAJCXJldHVybiBJUF9UVEw7Cisg
 CWNhc2UgTElOVVhfSVBfUkVUT1BUUzoKKyAJCXJldHVybiBJUF9SRVRPUFRTOworIAljYXNl
 IExJTlVYX0lQX1BLVElORk86CisgCQlyZXR1cm4gSVBfUEtUSU5GTzsKKyAJY2FzZSBMSU5V
 WF9JUF9SRUNWT1BUUzoKKyAJCXJldHVybiBJUF9SRUNWT1BUUzsKICAJY2FzZSBMSU5VWF9J
 UF9IRFJJTkNMOgogIAkJcmV0dXJuIElQX0hEUklOQ0w7CiAgCWNhc2UgTElOVVhfSVBfTVVM
 VElDQVNUX1RUTDoKKioqKioqKioqKioqKioqCioqKiA5NTgsOTY0ICoqKioKLS0tIDk2NCw5
 NzMgLS0tLQogIAljYXNlIExJTlVYX0lQX0RST1BfTUVNQkVSU0hJUDoKICAJCXJldHVybiBJ
 UF9EUk9QX01FTUJFUlNISVA7CiAgCWNhc2UgTElOVVhfSVBfUkVDVkVSUjoKKyAJY2FzZSBM
 SU5VWF9JUF9GUkVFQklORDoKICAJCXJldHVybiAtMjsJLyogaWdub3JlZCAqLworIAljYXNl
 IExJTlVYX0lQX01VTFRJQ0FTVF9BTEw6CisgCQlyZXR1cm4gLTM7CS8qIG5vcHJvdG9vcHQg
 Ki8KICAJZGVmYXVsdDoKICAJCXJldHVybiAtMTsKICAJfQoqKioqKioqKioqKioqKioKKioq
 IDk3NSw5ODAgKioqKgotLS0gOTg0LDk5MyAtLS0tCiAgCXN3aXRjaCAobG9wdCkgewogIAlj
 YXNlIExJTlVYX0lQVjZfVjZPTkxZOgogIAkJcmV0dXJuIElQVjZfVjZPTkxZOworIAljYXNl
 IExJTlVYX0lQVjZfTVVMVElDQVNUX0hPUFM6CisgCQlyZXR1cm4gSVBWNl9NVUxUSUNBU1Rf
 SE9QUzsKKyAJY2FzZSBMSU5VWF9JUFY2X01VTFRJQ0FTVF9BTEw6CisgCQlyZXR1cm4gLTM7
 CS8qIG5vcHJvdG9vcHQgKi8KICAJZGVmYXVsdDoKICAJCXJldHVybiAtMTsKICAJfQoqKioq
 KioqKioqKioqKioKKioqIDEwNzUsMTA4NCAqKioqCiAgCQlyZXR1cm4gRUlOVkFMOwogIAl9
 CiAgCiEgCWlmIChuYW1lID09IC0xKQogIAkJcmV0dXJuIEVJTlZBTDsKISAJaWYgKG5hbWUg
 PT0gLTIpCiAgCQlyZXR1cm4gMDsKICAJU0NBUkcoJmJzYSwgbmFtZSkgPSBuYW1lOwogIAog
 IAlyZXR1cm4gc3lzX3NldHNvY2tvcHQobCwgJmJzYSwgcmV0dmFsKTsKLS0tIDEwODgsMTEw
 MSAtLS0tCiAgCQlyZXR1cm4gRUlOVkFMOwogIAl9CiAgCiEgCXN3aXRjaCAobmFtZSkgewoh
 IAljYXNlIC0xOgogIAkJcmV0dXJuIEVJTlZBTDsKISAJY2FzZSAtMjoKICAJCXJldHVybiAw
 OworIAljYXNlIC0zOgorIAkJcmV0dXJuIEVOT1BST1RPT1BUOworIAl9CiAgCVNDQVJHKCZi
 c2EsIG5hbWUpID0gbmFtZTsKICAKICAJcmV0dXJuIHN5c19zZXRzb2Nrb3B0KGwsICZic2Es
 IHJldHZhbCk7CioqKioqKioqKioqKioqKgoqKiogMTEyNywxMTM0ICoqKioKICAJCXJldHVy
 biBFSU5WQUw7CiAgCX0KICAKISAJaWYgKG5hbWUgPT0gLTEpCiAgCQlyZXR1cm4gRUlOVkFM
 OwogIAlTQ0FSRygmYmdhLCBuYW1lKSA9IG5hbWU7CiAgCiAgCXJldHVybiBzeXNfZ2V0c29j
 a29wdChsLCAmYmdhLCByZXR2YWwpOwotLS0gMTE0NCwxMTU3IC0tLS0KICAJCXJldHVybiBF
 SU5WQUw7CiAgCX0KICAKISAJc3dpdGNoIChuYW1lKSB7CiEgCWNhc2UgLTE6CiEgCQlyZXR1
 cm4gRUlOVkFMOwohIAljYXNlIC0yOgogIAkJcmV0dXJuIEVJTlZBTDsKKyAJY2FzZSAtMzoK
 KyAJCXJldHVybiBFTk9QUk9UT09QVDsKKyAJfQogIAlTQ0FSRygmYmdhLCBuYW1lKSA9IG5h
 bWU7CiAgCiAgCXJldHVybiBzeXNfZ2V0c29ja29wdChsLCAmYmdhLCByZXR2YWwpOwpkaWZm
 IC1jckIgYS9saW51eF9zb2NrZXQuaCBiL2xpbnV4X3NvY2tldC5oCioqKiBhL2xpbnV4X3Nv
 Y2tldC5oCTIwMjEtMDktMjMgMDg6NTY6MjcuMDAwMDAwMDAwICswMjAwCi0tLSBiL2xpbnV4
 X3NvY2tldC5oCTIwMjUtMDYtMjcgMTE6NDc6NDcuOTExNDI1OTY5ICswMjAwCioqKioqKioq
 KioqKioqKgoqKiogMTA0LDEyMSAqKioqCi0tLSAxMDQsMTI5IC0tLS0KICAjZGVmaW5lIExJ
 TlVYX0lQX1RPUwkJMQogICNkZWZpbmUgTElOVVhfSVBfVFRMCQkyCiAgI2RlZmluZSBMSU5V
 WF9JUF9IRFJJTkNMCTMKKyAjZGVmaW5lIExJTlVYX0lQX1JFQ1ZPUFRTCTYKKyAjZGVmaW5l
 IExJTlVYX0lQX1JFVE9QVFMJNworICNkZWZpbmUgTElOVVhfSVBfUEtUSU5GTwk4CiAgI2Rl
 ZmluZSBMSU5VWF9JUF9SRUNWRVJSCTExCisgI2RlZmluZSBMSU5VWF9JUF9GUkVFQklORAkx
 NQogICNkZWZpbmUJTElOVVhfSVBfTVVMVElDQVNUX0lGCTMyCiAgI2RlZmluZQlMSU5VWF9J
 UF9NVUxUSUNBU1RfVFRMCTMzCiAgI2RlZmluZQlMSU5VWF9JUF9NVUxUSUNBU1RfTE9PUAkz
 NAogICNkZWZpbmUJTElOVVhfSVBfQUREX01FTUJFUlNISVAJMzUKICAjZGVmaW5lCUxJTlVY
 X0lQX0RST1BfTUVNQkVSU0hJUCAzNgorICNkZWZpbmUgTElOVVhfSVBfTVVMVElDQVNUX0FM
 TAk0OQogIAogIC8qCiAgICogT3B0aW9ucyBmb3IgW2dzXWV0c29ja29wdCgyKSwgSVBWNiBs
 ZXZlbC4KICAgKi8KICAKICAjZGVmaW5lIExJTlVYX0lQVjZfVjZPTkxZCQkyNgorICNkZWZp
 bmUgTElOVVhfSVBWNl9NVUxUSUNBU1RfSE9QUwkxOAorICNkZWZpbmUgTElOVVhfSVBWNl9N
 VUxUSUNBU1RfQUxMCTI5CisgCiAgCiAgLyoKICAgKiBPcHRpb25zIGZvciBbZ3NdZXRzb2Nr
 b3B0KDIpLCBUQ1AgbGV2ZWwuCg==
 --------------HXuMbjERfAh4cl99yy0iOL4o
 Content-Type: text/plain; charset=UTF-8; name="sock.txt"
 Content-Disposition: attachment; filename="sock.txt"
 Content-Transfer-Encoding: base64
 
 aHR0cHM6Ly9naXRodWIuY29tL29wZW5qZGsvamRrL2Jsb2IvbWFzdGVyL3NyYy9qYXZhLmJh
 c2UvdW5peC9uYXRpdmUvbGlibmlvL2NoL05ldC5jI0wzMDAKCmh0dHBzOi8vZ2l0aHViLmNv
 bS9OZXRCU0Qvc3JjL2Jsb2IvdHJ1bmsvc3lzL2NvbXBhdC9saW51eC9jb21tb24vbGludXhf
 c29ja2V0LmMjTDEwODAKCmdjYyAtc2hhcmVkIC1mUElDIHNvY2tob29rLmMgLW8gc29ja2hv
 b2suc28gLWxkbAoKamF2YWMgc29ja3Rlc3QuamF2YQoKZGlmZiAtY3JCIGEgYiA+IHBhdGNo
 CgpjZCB+L3NyYy9zeXMvY29tcGF0L2xpbnV4L2NvbW1vbi8gOyBjcCB+L011c2ljL2EvKiAu
 LyA7IHBhdGNoIC1wMSA8IH4vTXVzaWMvcGF0Y2gKCi4vYnVpbGQuc2ggLVUgLU8gfi9vYmog
 LWoyIC1tIGFtZDY0IC1hIHg4Nl82NCB0b29scwoKLi9idWlsZC5zaCAtVSAtTyB+L29iaiAt
 ajIgLW0gYW1kNjQgLWEgeDg2XzY0IGtlcm5lbD1HRU5FUklDCgouL2J1aWxkLnNoIC1VIC1P
 IH4vb2JqIC1qMiAtbSBhbWQ2NCAtYSB4ODZfNjQgbW9kdWxlcw==
 --------------HXuMbjERfAh4cl99yy0iOL4o
 Content-Type: text/x-csrc; charset=UTF-8; name="sockhook.c"
 Content-Disposition: attachment; filename="sockhook.c"
 Content-Transfer-Encoding: base64
 
 I2luY2x1ZGUgPHN0ZGlvLmg+CiNpbmNsdWRlIDxzeXMvc29ja2V0Lmg+CiNpbmNsdWRlIDxk
 bGZjbi5oPgojaW5jbHVkZSA8ZXJybm8uaD4KCiNkZWZpbmUgcGFyYW1zZXRzb2Nrb3B0IChp
 bnQgZmQsIGludCBsZXZlbCwgaW50IG9wdG5hbWUsIGNvbnN0IHZvaWQgKm9wdHZhbCwgc29j
 a2xlbl90IG9wdGxlbikKCmludCAoKm9yaWdpbmFsc2V0c29ja29wdCkgcGFyYW1zZXRzb2Nr
 b3B0OwoKaW50IHNldHNvY2tvcHQgcGFyYW1zZXRzb2Nrb3B0IHsKICAgIGlmICghb3JpZ2lu
 YWxzZXRzb2Nrb3B0KSB7CiAgICAgICAgb3JpZ2luYWxzZXRzb2Nrb3B0ID0gKGludCAoKikg
 cGFyYW1zZXRzb2Nrb3B0IClkbHN5bShSVExEX05FWFQsICJzZXRzb2Nrb3B0Iik7CiAgICB9
 CgogICAgaW50IHJlcyA9IG9yaWdpbmFsc2V0c29ja29wdChmZCwgbGV2ZWwsIG9wdG5hbWUs
 IG9wdHZhbCwgb3B0bGVuKTsKICAgIHByaW50ZigiaG9vayBjYWxsZWQgbGV2ZWw9JWkgb3B0
 bmFtZT0laSByZXM9JWkgZXJybm89JWkhXG4iLCBsZXZlbCwgb3B0bmFtZSwgcmVzLCBlcnJu
 byk7CgogICAgcmV0dXJuIDA7Cn0K
 --------------HXuMbjERfAh4cl99yy0iOL4o
 Content-Type: text/x-java; charset=UTF-8; name="socktest.java"
 Content-Disposition: attachment; filename="socktest.java"
 Content-Transfer-Encoding: base64
 
 CmltcG9ydCBqYXZhLm5ldC5EYXRhZ3JhbVNvY2tldDsKaW1wb3J0IGphdmEubmV0LkluZXRB
 ZGRyZXNzOwppbXBvcnQgamF2YS5uZXQuSW5ldDZBZGRyZXNzOwoKcHVibGljIGNsYXNzIHNv
 Y2t0ZXN0IHsKCiAgICBwdWJsaWMgc3RhdGljIHZvaWQgbWFpbihTdHJpbmcgYXJnc1tdKSB0
 aHJvd3MgRXhjZXB0aW9uIHsKICAgICAgICBuZXcgRGF0YWdyYW1Tb2NrZXQoKS5jb25uZWN0
 KEluZXRBZGRyZXNzLmdldEJ5TmFtZSgiMTI3LjAuMC4xIiksIDEyMzQpOwogICAgICAgIFN5
 c3RlbS5vdXQucHJpbnRsbigiaGFsZndheSEiKTsKICAgICAgICBuZXcgRGF0YWdyYW1Tb2Nr
 ZXQoKS5jb25uZWN0KEluZXQ2QWRkcmVzcy5nZXRCeU5hbWUoIjo6MSIpLCAxMjM0KTsKICAg
 ICAgICBTeXN0ZW0ub3V0LnByaW50bG4oIm9rISIpOwogICAgfQp9Cg==
 
 --------------HXuMbjERfAh4cl99yy0iOL4o--