bin/50873: src/usr.bin/netstat/vtw.c: 4 * weird coding ?

[dcb314%hotmail.com@localhost]

>Number:         50873
>Category:       bin
>Synopsis:       src/usr.bin/netstat/vtw.c: 4 * weird coding ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 29 17:50:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160229
>Organization:
>Environment:
>Description:

1.

src/usr.bin/netstat/vtw.c:272]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

Source code is

       if (!kbase | !klim)


Looks weird. Did someone muxup | and || ?

2.

src/usr.bin/netstat/vtw.c:303]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

    if (!base | !lim)


Duplicate

3.

src/usr.bin/netstat/vtw.c:372]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

  if (!kbase | !klim)


4.

src/usr.bin/netstat/vtw.c:402]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

   if (!base | !lim)

>How-To-Repeat:

>Fix: