NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

bin/50860: src/usr.sbin/isdn/isdnmonitor/main.c: 2 * redundant conditions



>Number:         50860
>Category:       bin
>Synopsis:       src/usr.sbin/isdn/isdnmonitor/main.c: 2 * redundant conditions
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 26 17:45:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160226
>Organization:
>Environment:
>Description:
1.


[src/usr.sbin/isdn/isdnmonitor/main.c:1172]: (style) Redundant condition: fullscreen. '!fullscreen || (fullscreen && !curses_ready)' is equivalent to '!fullscreen || !curses_ready'

Source code is
 
    if (!fullscreen || (fullscreen && (!curses_ready)))


2.

[src/usr.sbin/isdn/isdnmonitor/main.c:500]: (style) Redundant condition: debug_noscreen. '!debug_noscreen || (debug_noscreen && strcmp(what,"DBG")!=0)' is equivalent to '!debug_noscreen || strcmp(what,"DBG")!=0'


Source code is

        if ((!debug_noscreen) || (debug_noscreen && (((strcmp(what, "DBG"))) != 0)))


 
>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index