Re: CVS commit: src/sys/netinet

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Fri, Oct 16, 2026 at 03:57:15PM +0200, Thomas Klausner wrote:
> On Thu, Jul 23, 2026 at 09:49:19PM +0100, Taylor R Campbell wrote:
> > Module Name:	src
> > Committed By:	riastradh
> > Date:		Thu Jul 23 21:49:19 UTC 2026
> > 
> > Modified Files:
> > 	src/sys/netinet: if_arp.c
> > 
> > Log Message:
> > arp: Validate op on input, before creating any state.
> > 
> > PR kern/60491: arp creates state for invalid messages
> 
> I just had a panic triggered by this message:
> kernel diagnostic assertion "op == ARPOP_REPLY || op == ARPOP_REQUEST" failed: file "/usr/src/sys/netinet/if_arp.c", line 801

Ha so I'm not the only one, see
https://mail-index.netbsd.org/current-users/2026/10/11/msg047979.html


> 
> I have never seen this one before.
> 
> The only unusual thing I had going was a qemu with NetBSD downloading
> pkgsrc (via a tap bridge).

I also have a bridge, although there was only one member (the physical
interface) at the time of the panics.

> 
> A core dump is available.

I couldn't get one. This may help.
The difficulty is that when I add debug code in this function the
panic stops.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--