Re: 11: libssl not having NEEDED on crypto?

[Thomas Klausner <wiz%gatalith.at@localhost>]

On Fri, Sep 19, 2025 at 11:22:15AM +0100, Greg Troxel wrote:
> I'm rebuilding packages on multiple platforms for the pkgsrc freeze.
> 
> On a domU with netbsd-11 from about August 21, erlang-fast_tls fails to
> build, and the issue is linking libssl and not ending up with libcrypto:
> 
>   $ objdump -x /usr/lib/libssl.so|egrep NEEDED\|RPATH
>     NEEDED               libc.so.12
> 
> but on -10
> 
>   $ objdump -x /usr/lib/libssl.so|egrep NEEDED\|RPATH
>     NEEDED               libcrypto.so.15
>     NEEDED               libc.so.12
> 
> 
> I'd appreciate a clue among:
> 
>   Not known bug, will fix.
> 
>   Known bug, fixed, update to newer -11.
> 
>   It's valid for ssl not to NEEDED on libcrypto; fix fast_tls.  (with
>   rationale; this seems off to me)
> 
>   something else
>   
> 
> (I'll be updating to today's -11 anyway.)

I fixed this early August in -current, I thoguht I had this pulled up to -11.
 Thomas

--- Begin Message ---

• To: source-changes-full%NetBSD.org@localhost
• Subject: CVS commit: src/crypto/external/apache2/openssl/lib/libssl
• From: "Thomas Klausner" <wiz%netbsd.org@localhost>
• Date: Sat, 9 Aug 2025 18:36:03 +0000

Module Name:	src
Committed By:	wiz
Date:		Sat Aug  9 18:36:03 UTC 2025

Modified Files:
	src/crypto/external/apache2/openssl/lib/libssl: Makefile

Log Message:
libssl: link against libcrypto like we did for OpenSSL < 3.5

Also matches what upstream does.

Patch from RVP via current-users.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 \
    src/crypto/external/apache2/openssl/lib/libssl/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/crypto/external/apache2/openssl/lib/libssl/Makefile
diff -u src/crypto/external/apache2/openssl/lib/libssl/Makefile:1.4 src/crypto/external/apache2/openssl/lib/libssl/Makefile:1.5
--- src/crypto/external/apache2/openssl/lib/libssl/Makefile:1.4	Mon Jul 21 22:21:21 2025
+++ src/crypto/external/apache2/openssl/lib/libssl/Makefile	Sat Aug  9 18:36:03 2025
@@ -1,4 +1,4 @@
-#	$NetBSD: Makefile,v 1.4 2025/07/21 22:21:21 christos Exp $
+#	$NetBSD: Makefile,v 1.5 2025/08/09 18:36:03 wiz Exp $
 
 # RCSid:
 #	Id: Makefile,v 1.33 1998/11/11 11:53:53 sjg Exp
@@ -35,6 +35,8 @@ CRYPTODIST=	${NETBSDSRCDIR}/crypto
 
 .include "srcs.inc"
 
+LIBDPLIBS+=crypto ${.CURDIR}/../libcrypto
+
 AFLAGS+=-DELF
 
 # This is from the include/openssl directory; see ../libcrypto/Makefile

--- End Message ---