Re: reproducible kernel crash with quota

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Tue, Apr 12, 2022 at 08:52:28AM +0200, 6bone%6bone.informatik.uni-leipzig.de@localhost wrote:
> Hello,
> 
> since I already have some open bugs with reproducible kernel crashes, I'm
> only writing this to the mailing list.
> 
> how to reproduce the crash: /etc/rc.d/quota restart
> 
> dmesg:
> 
> [   412.047595] panic: kernel diagnostic assertion
> "dq->dq_ump->um_quotas[dq->dq _type] != vp" failed: file
> "/usr/src/sys/ufs/ufs/ufs_quota.c", line 978
> [   412.047595] cpu8: Begin traceback...
> [   412.047595] vpanic() at netbsd:vpanic+0x156
> [   412.057595] kern_assert() at netbsd:kern_assert+0x4b
> [   412.057595] dqflush() at netbsd:dqflush+0x92
> [   412.057595] quota1_handle_cmd_quotaoff() at
> netbsd:quota1_handle_cmd_quotaof f+0x120

I wonder if, when quota1_handle_cmd_quotaoff() can't get an exclusive lock
for a vnode, could fail to free the associated quota structure.
Shoudln't it wait for the exclusive vnlock or retry in this case ?

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--